Improve assertChanges method in MarkersChangeListener #2569#2585
Merged
fedejeanne merged 1 commit intoeclipse-platform:masterfrom Mar 24, 2026
Merged
Conversation
…m#2569 Use assertAll and more details about the missing/extra markers. Contributes to eclipse-platform#2569
There was a problem hiding this comment.
Pull request overview
This PR improves diagnostics in MarkersChangeListener.assertChanges (used by marker-related resource tests) by grouping assertions and reporting detailed mismatches for added/removed/changed marker deltas, helping investigate sporadic failures like #2569.
Changes:
- Refactors
assertChangesto snapshot deltas once and compute actual vs. expected added/removed/changed marker lists. - Uses JUnit 5
Assertions.assertAllto report all assertion failures together. - Adds explicit checks for unsupported
IMarkerDeltakinds and exact per-kind marker equality (order-independent).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use assertAll and more details about the missing/extra markers.
Contributes to
#2569